Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added width compatibility for mobiles! #140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shreyasbapat
Copy link

Solves #139
@bitprophet Please Review!

@shreyasbapat
Copy link
Author

During the build of alabaster docs, I am facing this issue!:

Extension error:Could not import extension releases (exception: No module named releases)

So, after merging this, we can get something like this without further tweaks:
https://poliastro-sh.readthedocs.io/en/doc-theme-change/

@bitprophet
Copy link
Collaborator

Re: #139 - can you provide some details on exactly what behavior I should be confirming is fixed here? Thanks! Offhand I don't see a huge problem with this but I'm still curious what exactly it's solving. (At this point in time I am hoping nobody would ever try loading up a Sphinx doc site on <250px display...probably? :D)

@shreyasbapat
Copy link
Author

shreyasbapat commented Aug 8, 2018

Hi! @bitprophet . Currently, if you try to view https://inb.readthedocs.io/en/latest/ in mobile, or any device less than 450px(which is a lot TBH), you have to scroll left and right to read things (Which gets quite disastrous).

I kept 250px to be on a safe side. Mobiles generally have screen size from 290px to 400 px.

See this, in which I fixed this problem.
https://poliastro-sh.readthedocs.io/en/doc-theme-change
This is more responsive and user friendly. :)

At this point in time I am hoping nobody would ever try loading up a Sphinx doc site on <250px display...probably? :D)

True, indeed that's why I kept it as a min device width :D

@shreyasbapat
Copy link
Author

One can always put some custom CSS, but I guess responsiveness must be shipped with the theme.

@bitprophet bitprophet added this to the 0.8 milestone Aug 8, 2018
@pauloxnet
Copy link

I noticed this bug in all alabaster themed website using my mobile phone.
@bitprophet please merge @shreyasbapat PR, thanks!

@ykrods
Copy link

ykrods commented Jul 5, 2019

I make a PR related this! I am glad if you can see!
#157

@tfardet
Copy link

tfardet commented Apr 27, 2022

Is there a reason not to merge this PR?
It does solve the compatibility issue on mobile devices which is otherwise making lines overflow.

@bitprophet bitprophet deleted the branch sphinx-doc:master January 13, 2023 00:42
@bitprophet bitprophet closed this Jan 13, 2023
@AA-Turner AA-Turner reopened this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants